Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Rails/RootPathnameMethods to detect offenses on Dir.[] #1003

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

r7kamura
Copy link
Contributor

Added support for Dir.[].

One of the most commonly used example of this pattern is the following code, generated by rspec-rails gem:

# bad
Dir[Rails.root.join('spec/support/**/*.rb')].each { |f| require f }

# good
Rails.root.glob('spec/support/**/*.rb').each { |f| require f }

Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.
  • If this is a new cop, consider making a corresponding update to the Rails Style Guide.

@r7kamura r7kamura force-pushed the root-pathname-methods-index branch from ea9aafc to d57ed94 Compare May 10, 2023 19:23
@koic
Copy link
Member

koic commented May 13, 2024

This looks good to me. Can you rebase with the latest master branch?

@r7kamura r7kamura force-pushed the root-pathname-methods-index branch from d57ed94 to d876323 Compare May 13, 2024 11:39
@koic koic merged commit 98a8c99 into rubocop:master Aug 15, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants